Refactor LabelNames to return model.LabelNames type for consistency#1850
Merged
Conversation
…or consistency Signed-off-by: yshngg <yshngg@outlook.com>
yshngg
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
yshngg
added a commit
to yshngg/prometheus-mcp-server
that referenced
this pull request
Aug 1, 2025
```diff -// TODO: replace []string with model.LabelNames ? prometheus/client_golang#1850 +// TODO: Replace []string with model.LabelNames (see prometheus/client_golang#1850). ```
yshngg
added a commit
to yshngg/prometheus-mcp-server
that referenced
this pull request
Aug 1, 2025
* 💡(metadata_query): Add PR reference to TODO comment about LabelNames replacement [Explanation: Added GitHub PR link (#1850) to existing TODO comment to provide context for future type replacement from []string to model.LabelNames] * 💡(labels.go): Improve TODO comment clarity and formatting ```diff -// TODO: replace []string with model.LabelNames ? prometheus/client_golang#1850 +// TODO: Replace []string with model.LabelNames (see prometheus/client_golang#1850). ```
bwplotka
approved these changes
Aug 19, 2025
bwplotka
left a comment
bwplotka
left a comment
Member
There was a problem hiding this comment.
This is breaking change, but API is still experimental, so LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.